Closed
Conversation
Member
Author
|
I'm confused as to why CI is failing for a rust fmt command, I did not think we used rustfmt in the |
Member
|
@tcharding , |
Member
Author
|
Oh cool, thanks for the explanation @sanket1729! |
6170f51 to
5f27459
Compare
We support many versions of rustc by design, this puts us in the following predicament: 1. Linting with a newer version of clippy throws a warning for a newly introduced default lint. 2. In order to allow the lint we must use the lint by name but this lint does not exist in earlier versions of clippy, so we get a warning `unknown lint` when linting with the earlier version. We want to have our cake and eat it too, we can do this by allowing unknown lints. Doing so enables (1) while preventing (2). To demonstrate this use case `cargo +1.36 check` emits: warning: unknown lint: `broken_intra_doc_links` With this patch applied there is no such warning emitted.
5f27459 to
3724a44
Compare
Member
Author
|
Based off comments in the same PR as this on rust-bitcoin, this PR is not useful. Please excuse the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We support many versions of rustc by design, this puts us in the following predicament:
unknown lintwhen linting with the earlier version.We want to have our cake and eat it too, we can do this by allowing unknown lints. Doing so enables (1) while preventing (2).
As demonstration
cargo +1.36 checkemits:With this patch applied there is no such warning emitted.
The change in this PR has also been submitted in
bitcoin_hashes, for brevity it is likely easier if we discuss the failings/merits of this work in a single place on that PR. Thanks.