cargo-rbmt: move api files into package#86
Merged
tcharding merged 1 commit intorust-bitcoin:masterfrom Mar 10, 2026
Merged
Conversation
tcharding
approved these changes
Feb 20, 2026
Member
There was a problem hiding this comment.
utACK 4977fc0
Will wait for @apoelstra before merging.
The original push for this change was to address how api files were namespaced under the top level api/ dir, should it be with the package manifest name or match the package directory. This side steps the issue by just putting the api/ dir under the package directory. API files are now broken up by package. Probably more helpfully though, this change allows a workspace and a single package repo to be treated the same, simplify configs and rbmt. A possible downside to pushing the api files into the package directory is that they then get published by default. So a quick check is added to make sure a package manifest excludes the api/ dir.
4977fc0 to
8278a3e
Compare
Collaborator
Author
|
8278a3e: rebased |
Member
|
@apoelstra has had 3 weeks, going to go ahead and merge this. I'll just throw you under the bus @nyonson if this pisses him off ... just kidding. |
tcharding
approved these changes
Mar 10, 2026
Member
|
utACK 8278a3e Yeah, this seems reasonable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original push for this change was to address how api files were namespaced under the top level api/ dir, should it be with the package manifest name or match the package directory. This side steps the issue by just putting the api/ dir under the package directory. API files are now broken up by package.
Probably more helpfully though, this change allows a workspace and a single package repo (e.g. rust-psbt) to be treated the same, simplify configs and rbmt.
A possible downside to pushing the api files into the package directory is that they then get published by default. So a quick check is added to make sure a package manifest excludes the api/ dir.