DO NOT MERGE: Backport 'Fix no_std MSRV Fixes' to 0.28.0#985
Closed
tcharding wants to merge 1 commit intorust-bitcoin:0.28.xfrom
Closed
DO NOT MERGE: Backport 'Fix no_std MSRV Fixes' to 0.28.0#985tcharding wants to merge 1 commit intorust-bitcoin:0.28.xfrom
no_std MSRV Fixes' to 0.28.0#985tcharding wants to merge 1 commit intorust-bitcoin:0.28.xfrom
Conversation
no_std MSRV Fixes #690, #947no_std MSRV Fixes' to 0.28
no_std MSRV Fixes' to 0.28no_std MSRV Fixes' to 0.28.0
Member
Author
|
Possibly of interest to @devrandom, @mcroad. Cheers. |
TheBlueMatt
approved these changes
May 3, 2022
Member
|
@tcharding I'm happy to merge this but I need you to remove DO NOT MERGE from the title :). Alternately you can close it in favor of #986. |
Member
Author
|
#986 it is :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #690 onto the v0.28.0 tagged release.
I'm not sure exactly how the release will be done using this but for the record what I did was:
no_stdunder 1.29 (MSRV) #690 (fixing trivial conflicts)The only conflict was that #690 removed
PIN_VERSIONS(becausemasteris already not using 1.29 anymore) where as the backport leaves pinning in place.Please note; CI doesn't appear to run, I guess its because CI is configured to only run for merges into master, can we change the settings to run CI for the
0.28.xbase branch also?