Skip to content

Remove deprecated method use for sighash conversion#913

Merged
apoelstra merged 1 commit intomasterfrom
dr-orlovsky-patch-1
Mar 28, 2022
Merged

Remove deprecated method use for sighash conversion#913
apoelstra merged 1 commit intomasterfrom
dr-orlovsky-patch-1

Conversation

@dr-orlovsky
Copy link
Copy Markdown
Collaborator

Post-merge #796 follow-up. Feel free to add other changes/nits which hadn't get into #796.

Post-merge #796 follow-up. Feel free to add other changes/nits which hadn't get into #796.
@dr-orlovsky dr-orlovsky added trivial Obvious, easy and quick to review (few lines or doc-only...) RC fix labels Mar 28, 2022
@dr-orlovsky dr-orlovsky added this to the 0.28.0 milestone Mar 28, 2022
Copy link
Copy Markdown
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c3d30d5

@tcharding
Copy link
Copy Markdown
Member

tcharding commented Mar 28, 2022

ACK c3d30d5

Thanks.

@sanket1729
Copy link
Copy Markdown
Member

sanket1729 commented Mar 28, 2022

@tcharding , I think this is missing your approval. You can also try merging this with merge script from https://github.com/bitcoin-core/bitcoin-maintainer-tools.

The README has detailed instructions.

Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c3d30d5

@apoelstra apoelstra merged commit e2cae76 into master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

trivial Obvious, easy and quick to review (few lines or doc-only...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants