Issue #394 - Refactor Block::merkle_root() #775
Merged
apoelstra merged 2 commits intorust-bitcoin:masterfrom Jan 13, 2022
nilswloewen:issue_394
Merged
Issue #394 - Refactor Block::merkle_root() #775apoelstra merged 2 commits intorust-bitcoin:masterfrom nilswloewen:issue_394
apoelstra merged 2 commits intorust-bitcoin:masterfrom
nilswloewen:issue_394
Conversation
Block::compute_merkle_root() and deprecate Block::merkle_root().
Member
|
Ha! The title of this PR threw me, I thought it was an issue not a PR :) |
Member
|
This looks fine to me because it's just a 2-line function, but it might be clearer if the deprecated function just called the non-deprecated one rather than duplicating the logic. concept ACK changing the name. |
tcharding
reviewed
Jan 12, 2022
Contributor
Author
|
Thanks for the feedback @apoelstra and @tcharding. I've made the changes you've suggested. |
Member
|
Thanks, LGTM. |
Collaborator
|
I think squashing would be useful. |
Kixunil
approved these changes
Jan 13, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
Block::merkle_root()toBlock::compute_merkle_root()and deprecateBlock::merkle_root().