Change type of final script witness to Witness from Vec<Vec<u8>>#774
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Jan 11, 2022
Merged
Change type of final script witness to Witness from Vec<Vec<u8>>#774apoelstra merged 1 commit intorust-bitcoin:masterfrom
apoelstra merged 1 commit intorust-bitcoin:masterfrom
Conversation
dr-orlovsky
previously approved these changes
Jan 11, 2022
Collaborator
dr-orlovsky
left a comment
There was a problem hiding this comment.
ACK 68b21f696dfe9d4e4592334967cd876731dd6f31
Kixunil
previously approved these changes
Jan 11, 2022
Collaborator
Kixunil
left a comment
There was a problem hiding this comment.
ACK 68b21f696dfe9d4e4592334967cd876731dd6f31
Really cool how the code composes so that this change is simple. :)
RCasatta
reviewed
Jan 11, 2022
68b21f6 to
9a8ab3f
Compare
Member
Author
|
Addressed the nits. |
Kixunil
approved these changes
Jan 11, 2022
RCasatta
approved these changes
Jan 11, 2022
apoelstra
approved these changes
Jan 11, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing this would certainly help APIs downstream that operate on &Witness because they would not conversion from &Vec<Vec> to &Witness.