Skip to content

Add FromStr implementation for a TweakedPublicKey#772

Closed
dr-orlovsky wants to merge 1 commit intorust-bitcoin:masterfrom
BP-WG:taproot/from_str
Closed

Add FromStr implementation for a TweakedPublicKey#772
dr-orlovsky wants to merge 1 commit intorust-bitcoin:masterfrom
BP-WG:taproot/from_str

Conversation

@dr-orlovsky
Copy link
Copy Markdown
Collaborator

@dr-orlovsky dr-orlovsky commented Jan 11, 2022

This extract controversial commit from a PR #696.

Please see discussion in #696 (comment)

@dr-orlovsky dr-orlovsky added the trivial Obvious, easy and quick to review (few lines or doc-only...) label Jan 11, 2022
@dr-orlovsky dr-orlovsky added this to the 0.28.0 milestone Jan 11, 2022
@dr-orlovsky dr-orlovsky mentioned this pull request Jan 11, 2022
Merged
@apoelstra
Copy link
Copy Markdown
Member

apoelstra commented Jan 11, 2022

After reading @sanket1729's argument, that TweakedPublicKey is basically an intermediate type used to enforce safety of the Address API, I think I agree with him.

(weak) concept NACK

@Kixunil
Copy link
Copy Markdown
Collaborator

Kixunil commented Jan 11, 2022

Same here. So far there's only one widely-accepted encoding of tweaked public key: a P2TR address.
But I think it'd be good to add doc comment: "Use Address to safely (de)serialize TweakedPublicKey"

@dr-orlovsky
Copy link
Copy Markdown
Collaborator Author

dr-orlovsky commented Jan 15, 2022

Agree with the arguments, closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

trivial Obvious, easy and quick to review (few lines or doc-only...)

Projects

None yet

Milestone

0.28.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dr-orlovsky @apoelstra @Kixunil