wrap u8 and LeafVersion in backticks and square bracket in doc#766
Merged
dr-orlovsky merged 1 commit intorust-bitcoin:masterfrom Jan 10, 2022
Conversation
Collaborator
|
ACK 9835736 thanks! |
Collaborator
|
@Kixunil you haven't actually used "Approve" GitHub button and this PR is still unmergable because of that |
Kixunil
approved these changes
Jan 10, 2022
Collaborator
|
Should've drink coffee before work :D |
Member
|
Does the Bitcoin Core github merge script also insist that you use the "approve" button? |
Collaborator
I can confirm the push is declined if there aren't 2 approve button clicks |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this minor doc issue while reviewing(learning) previous merged PR.
Close #763