Re-export SigHashType in lib.rs#749
Merged
RCasatta merged 1 commit intorust-bitcoin:masterfrom Dec 27, 2021
Merged
Conversation
Using the latest version of rust-bitcoin master on rust-miniscript errors on bitcoin::SigHashType not found. In the original PR, I only renamed the export to ECDSASigHashType, but original re-export should also be there in lib.rs to avoid to breaking changes downstream.
5289868 to
3eea63e
Compare
sanket1729
commented
Dec 25, 2021
| pub use util::ecdsa::PrivateKey; | ||
| #[deprecated(since = "0.26.1", note = "Please use `ecdsa::PublicKey` instead")] | ||
| pub use util::ecdsa::PublicKey; | ||
| #[allow(deprecated)] |
Member
Author
There was a problem hiding this comment.
It kinda sucks that I have to have this to avoid a warning when this is just for re-exporting.
apoelstra
approved these changes
Dec 26, 2021
RCasatta
approved these changes
Dec 27, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the latest version of rust-bitcoin master on rust-miniscript
errors on bitcoin::SigHashType not found. In the original PR, I only
renamed the export to ECDSASigHashType, but original re-export should
also be there in lib.rs to avoid breaking changes downstream.
Fixup to #702
Before this PR,
After this PR,