Merged
Conversation
This changes `rustc-args`, which doesn't do what we want, to `rustdoc-args`, which does.
Contributor
|
https://docs.rs/about/metadata for reference |
Collaborator
Author
|
@dpc the other part of it is knowing the difference between |
Collaborator
Author
|
@apoelstra makes sure docs.rs builds docs with correct flag so that all the work on documenting features actually makes sense - they don't appear there without the flag. |
RCasatta
approved these changes
Dec 27, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
rustc-args, which doesn't do what we want, torustdoc-args,which does.
Because of huge value/effort ratio assigning medium priority and 0.28 milestone - would be a real shame to release without this.