Skip to content

add helpful message to division-by-zero panic#743

Merged
sanket1729 merged 1 commit intorust-bitcoin:masterfrom
6293:helpful-message-zerodiv
Dec 15, 2021
Merged

add helpful message to division-by-zero panic#743
sanket1729 merged 1 commit intorust-bitcoin:masterfrom
6293:helpful-message-zerodiv

Conversation

@6293
Copy link
Copy Markdown
Contributor

@6293 6293 commented Dec 14, 2021

Closes #739

Kixunil
Kixunil approved these changes Dec 14, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3e19983

Thanks!

@Kixunil Kixunil added enhancement one ack PRs that have one ACK, so one more can progress them trivial Obvious, easy and quick to review (few lines or doc-only...) labels Dec 14, 2021
sanket1729
sanket1729 approved these changes Dec 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cr ACK 3e19983

@sanket1729 sanket1729 merged commit b3cd308 into rust-bitcoin:master Dec 15, 2021
@dr-orlovsky dr-orlovsky mentioned this pull request Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kixunil Kixunil Kixunil approved these changes

@sanket1729 sanket1729 sanket1729 approved these changes

Assignees

No one assigned

Labels

enhancement one ack PRs that have one ACK, so one more can progress them trivial Obvious, easy and quick to review (few lines or doc-only...)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add helpful message to division-by-zero panic

3 participants

@6293 @Kixunil @sanket1729