add MAX_MONEY public constant to Amount#742
Merged
RCasatta merged 1 commit intorust-bitcoin:masterfrom Dec 16, 2021
Merged
Conversation
Kixunil
reviewed
Dec 14, 2021
Collaborator
Kixunil
left a comment
There was a problem hiding this comment.
Could you add the same constant for unsigned Amount too, please?
Note for other reviewers: Mul::mul is not const so 21_000_000 * Self::ONE_BTC wouldn't work.
ae95829 to
b09cf9c
Compare
Contributor
Author
|
@Kixunil thanks, updated. |
Member
|
We should address why @dpc reacted with thumbs down before we proceed on this. |
Kixunil
requested changes
Dec 15, 2021
src/util/amount.rs
Outdated
Collaborator
There was a problem hiding this comment.
Looks like you forgot to remove Signed :)
Collaborator
|
@sanket1729 I think he thought it is an implementation of #620 but it isn't. @dpc could you clarify? |
b09cf9c to
ab12410
Compare
Contributor
|
Correct. Please don't mind me. |
Kixunil
approved these changes
Dec 15, 2021
RCasatta
approved these changes
Dec 16, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #740