Super-trivial: Implement FusedIterator for Instructions#733
Merged
RCasatta merged 1 commit intorust-bitcoin:masterfrom Dec 3, 2021
Merged
Super-trivial: Implement FusedIterator for Instructions#733RCasatta merged 1 commit intorust-bitcoin:masterfrom
FusedIterator for Instructions#733RCasatta merged 1 commit intorust-bitcoin:masterfrom
Conversation
`Instructions` guarantee to return `None` from empty iterator so we should signal this in type system so that the code can be optimized better. This also adds a test to make sure this property holds.
87f36dd to
04a8f89
Compare
sanket1729
approved these changes
Dec 1, 2021
Member
sanket1729
left a comment
There was a problem hiding this comment.
utACK 04a8f89. Any special reasons for doing this?
romanz
approved these changes
Dec 2, 2021
Collaborator
Author
Was just writing some code and wondering whether it's already fused or not. So part of the reason is documentation value. |
RCasatta
approved these changes
Dec 3, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructionsguarantee to returnNonefrom empty iterator so weshould signal this in type system so that the code can be optimized
better. This also adds a test to make sure this property holds.