Add unit test for bitcoin_merkle_root functions#711
Merged
RCasatta merged 1 commit intorust-bitcoin:masterfrom Nov 22, 2021
Merged
Add unit test for bitcoin_merkle_root functions#711RCasatta merged 1 commit intorust-bitcoin:masterfrom
RCasatta merged 1 commit intorust-bitcoin:masterfrom
Conversation
Kixunil
requested changes
Nov 19, 2021
Collaborator
Kixunil
left a comment
There was a problem hiding this comment.
Please fix the CI failure.
Also while useful, I think it'd be even better to somehow unify the two functions so same logic would always be guaranteed.
We test `bitcoin_merkle_root` over in the `blockdata::block` module. Although the `bitcoin_merkle_root` and `bitcoin_merkle_root_inline` functions are almost identical there is enough index manipulation done that it is not immediately obvious that the code is error free. Add a unit test that verifies that the two functions return the same resulting merkle root.
5125727 to
e047950
Compare
Kixunil
approved these changes
Nov 22, 2021
Collaborator
|
ACK e047950 |
RCasatta
approved these changes
Nov 22, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We test
bitcoin_merkle_rootover in theblockdata::blockmodule.Although the
bitcoin_merkle_rootandbitcoin_merkle_root_inlinefunctions are almost identical there is enough index manipulation done
that it is not immediately obvious that the code is error free.
Add a unit test that verifies that the two functions return the same
resulting merkle root.
This was done in response to #394.