Skip to content

Tapsighash test vectors#705

Merged
RCasatta merged 1 commit intorust-bitcoin:masterfrom
sanket1729:tapsighash_test_vectors
Jan 3, 2022
Merged

Tapsighash test vectors#705
RCasatta merged 1 commit intorust-bitcoin:masterfrom
sanket1729:tapsighash_test_vectors

Conversation

@sanket1729
Copy link
Copy Markdown
Member

Based on #695 . Adds the remaining test vectors to test sighash paths. Will rebase after #695

@sanket1729 sanket1729 force-pushed the tapsighash_test_vectors branch from 003848f to e0772d6 Compare November 22, 2021 17:36
@dr-orlovsky
Copy link
Copy Markdown
Collaborator

Needs rebase

@Kixunil Kixunil added the waiting for author This can only progress if the author responds to a request. label Dec 2, 2021
@sanket1729 sanket1729 force-pushed the tapsighash_test_vectors branch from e0772d6 to 31100a3 Compare December 12, 2021 16:26
@sanket1729 sanket1729 removed the waiting for author This can only progress if the author responds to a request. label Dec 15, 2021
@sanket1729 sanket1729 force-pushed the tapsighash_test_vectors branch 2 times, most recently from 9c7cbb2 to 6648477 Compare December 23, 2021 18:50
apoelstra
apoelstra previously approved these changes Dec 24, 2021
Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6648477ff2471a79451952aa4f32cb9cd2a4fe58

@RCasatta
Copy link
Copy Markdown
Collaborator

Needs rebase

@sanket1729
Copy link
Copy Markdown
Member Author

Rebased

Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 92ee5a7

Copy link
Copy Markdown
Collaborator

@RCasatta RCasatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 92ee5a7

Maybe one day we can have an internal-only crate test-utilities used as a dev-dependency where we can put things like fn bip_341_read_json

@RCasatta RCasatta merged commit 4fa477c into rust-bitcoin:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants