Skip to content

Return the correct LeafVersion when building a Taproot ControlBlock#703

Merged
sanket1729 merged 1 commit intorust-bitcoin:masterfrom
afilini:fix/return-correct-leaf-ver-spend-info
Nov 16, 2021
Merged

Return the correct LeafVersion when building a Taproot ControlBlock#703
sanket1729 merged 1 commit intorust-bitcoin:masterfrom
afilini:fix/return-correct-leaf-ver-spend-info

Conversation

@afilini
Copy link
Copy Markdown
Contributor

@afilini afilini commented Nov 16, 2021

No description provided.

Copy link
Copy Markdown
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also done in #695. I can drop the commit entirely.

Copy link
Copy Markdown
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also done in #695. I can drop the commit entirely there

@Kixunil
Copy link
Copy Markdown
Collaborator

Kixunil commented Nov 16, 2021

I like having smaller commits but merging it myself would feel like imposing it on others. :)

Copy link
Copy Markdown
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0af5a43

@sanket1729 sanket1729 merged commit df72500 into rust-bitcoin:master Nov 16, 2021
@sanket1729
Copy link
Copy Markdown
Member

Done. @Kixunil if you can ACK <commit-hash> it would be useful because it helps tools like https://github.com/bitcoin-core/bitcoin-maintainer-tools to generate a nice merge commit message as shown for this PR.

I also recommend using it whenever you merge a commit, it allows you to sign off commits with your key.

@Kixunil
Copy link
Copy Markdown
Collaborator

Kixunil commented Nov 16, 2021

Thanks for info! I will have to look into proper GPG commits setup with git and Qubes. Was only doing tags so far by manually copying repo to a different VM. :D

@sanket1729 sanket1729 mentioned this pull request Nov 19, 2021
@afilini afilini deleted the fix/return-correct-leaf-ver-spend-info branch November 23, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants