Skip to content

Hotfix for secp256k1 alloc feature#694

Merged
dr-orlovsky merged 1 commit intorust-bitcoin:masterfrom
BP-WG:fix/secp-alloc
Dec 3, 2021
Merged

Hotfix for secp256k1 alloc feature#694
dr-orlovsky merged 1 commit intorust-bitcoin:masterfrom
BP-WG:fix/secp-alloc

Conversation

@dr-orlovsky
Copy link
Copy Markdown
Collaborator

@dr-orlovsky dr-orlovsky commented Nov 12, 2021

Latest merges has broken builds since they have introduced alloc feature in secp256k1 which appeared only in 0.20.3 version, while Cargo.toml here still required 0.20.2

This was not caught by CI since it always runs with cargo update

Copy link
Copy Markdown
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4eedd46

@tcharding
Copy link
Copy Markdown
Member

tcharding commented Nov 26, 2021

ACK 4eedd46

Verified that using secp256k1 = { version = "=0.20.2", default-features = false } does indeed fail.

the package `bitcoin` depends on `secp256k1`, with features: `alloc` but `secp256k1` does not have these features.

Copy link
Copy Markdown
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4eedd46

@dr-orlovsky dr-orlovsky merged commit dd15ce4 into rust-bitcoin:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants