transactions: add a note about get_vsize and standardness rules#665
Merged
sanket1729 merged 1 commit intorust-bitcoin:masterfrom Dec 27, 2021
Merged
Conversation
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Kixunil
approved these changes
Sep 25, 2021
Collaborator
Kixunil
left a comment
There was a problem hiding this comment.
Looks good. If you'd like to make it awesome consider adding some guidance in which applications this matters (probably only nodes?).
Contributor
Author
|
This matters for nodes, but especially for any application crafting then broadcasting exotic transactions. IIRC i had put that in the doc comment?
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
Le samedi 25 septembre 2021 à 8:22 PM, Martin Habovštiak ***@***.***> a écrit :
… @Kixunil approved this pull request.
Looks good. If you'd like to make it awesome consider adding some guidance in which applications this matters (probably only nodes?).
—
You are receiving this because you authored the thread.
Reply to this email directly, [view it on GitHub](#665 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3F65TEYICSJVGZHXQULUDYHPFANCNFSM5EWN7LYQ).
Triage notifications on the go with GitHub Mobile for [iOS](https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or [Android](https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub).
|
sanket1729
approved these changes
Dec 27, 2021
Member
sanket1729
left a comment
There was a problem hiding this comment.
ACK 826fed5. Verified the implementation with bitcoin core.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If they ever hit a discrepancy they must really be doing something dodgy but hey :)