Add i686 to tested architectures#659
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Sep 20, 2021
Merged
Conversation
be11ce5 to
bbefe33
Compare
Collaborator
Author
|
Anyone has an idea why apt can't install it on Ubuntu? It works fine in Debian 10. |
This adds i686 to CI which can help catching pointer-size-related bugs such as the one addressed by rust-bitcoin#658.
bbefe33 to
f2042bd
Compare
TheBlueMatt
approved these changes
Sep 19, 2021
Member
|
We should probably figure out how to run fuzzing on 32-bit architectures, too. |
Collaborator
|
Another option for the CI to test i686 and many other arch is leveraging the cross test. rust-bitcoin/.github/workflows/rust.yml Lines 46 to 63 in b7f9849 |
Collaborator
Author
|
As I understand it that one uses emulation and i686 can be run directly on x86_64, which should be faster so that's why opted for it. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds i686 to CI which can help catching pointer-size-related bugs
such as the one addressed by #658.
Opening a new PR seemed more appropriate than adding it to #658 I can change it if you disagree.