Changes for checking script size and returning Result<Address, Error> for p2sh#655
Merged
dr-orlovsky merged 1 commit intorust-bitcoin:masterfrom Sep 16, 2021
Merged
Conversation
dr-orlovsky
approved these changes
Sep 16, 2021
Collaborator
dr-orlovsky
left a comment
There was a problem hiding this comment.
ACK. Checked against Bitcoin Core: it has the same named constant with the same value: https://github.com/bitcoin/bitcoin/blob/f4e12fd50c23875f4b5f272c94449eb81de43d5d/src/script/script.h#L32-L33
Congrants with the first contribution!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added changes in the p2sh function to return a result (#650), created an error for ExcessiveScriptSize, added a constant for MAX_SCRIPT_ELEMENT_SIZE and added a test where the script size exceeds 520.