Skip to content

Improvements to Error types (part 4)#625

Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom
BP-WG:fix/error-derives-4
Sep 8, 2021
Merged

Improvements to Error types (part 4)#625
apoelstra merged 1 commit intorust-bitcoin:masterfrom
BP-WG:fix/error-derives-4

Conversation

@dr-orlovsky
Copy link
Copy Markdown
Collaborator

Removes controversial aspects from #560 (all io::Error-related changes) and leaves the rest

@dr-orlovsky dr-orlovsky added the API break This PR requires a version bump for the next release label Jun 27, 2021
@dr-orlovsky dr-orlovsky added this to the 0.27.0 milestone Jun 27, 2021
@dr-orlovsky dr-orlovsky marked this pull request as ready for review June 27, 2021 17:06
sanket1729
sanket1729 previously approved these changes Jun 27, 2021
Copy link
Copy Markdown
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack 15545a5

Kixunil
Kixunil previously approved these changes Jun 28, 2021
Copy link
Copy Markdown
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@dr-orlovsky dr-orlovsky dismissed stale reviews from Kixunil and sanket1729 via 994079b August 1, 2021 19:09
@dr-orlovsky
Copy link
Copy Markdown
Collaborator Author

Had to rebase, so @sanket1729 will acknowledge re-review

Copy link
Copy Markdown
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 994079b

Copy link
Copy Markdown
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK

Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 994079b

@apoelstra apoelstra merged commit 13a6c3b into rust-bitcoin:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API break This PR requires a version bump for the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants