Fix documentation referencing macro var#623
Merged
sanket1729 merged 1 commit intorust-bitcoin:masterfrom Aug 13, 2021
Merged
Conversation
Kixunil
approved these changes
Aug 2, 2021
Collaborator
Kixunil
left a comment
There was a problem hiding this comment.
utACK, multiple doc attributes should get concatenated - TIL
dr-orlovsky
approved these changes
Aug 9, 2021
Collaborator
dr-orlovsky
left a comment
There was a problem hiding this comment.
Good catch! Feel free to ignore my Nit and merge PR once there will be a second ACK
Comment on lines
+54
to
+56
| #[doc = "The tag used for ["] | ||
| #[doc = $sname] | ||
| #[doc = "]"] |
Collaborator
There was a problem hiding this comment.
Nit: we need `` for formatting
Suggested change
| #[doc = "The tag used for ["] | |
| #[doc = $sname] | |
| #[doc = "]"] | |
| #[doc = "The tag used for [`"] | |
| #[doc = $sname] | |
| #[doc = "`]"] |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current docs https://docs.rs/bitcoin/0.26.2/bitcoin/util/taproot/index.html show
[$newtype]because macro vars aren't expanded in docs