Skip to content

std -> core#614

Merged
TheBlueMatt merged 1 commit intorust-bitcoin:masterfrom
devrandom:2021-06-nostd1
Jun 14, 2021
Merged

std -> core#614
TheBlueMatt merged 1 commit intorust-bitcoin:masterfrom
devrandom:2021-06-nostd1

Conversation

@devrandom
Copy link
Copy Markdown
Contributor

@devrandom devrandom commented Jun 9, 2021

Use the core crate when possible, in preparation for no_std mode.

See #603 and #409

@devrandom devrandom mentioned this pull request Jun 9, 2021
Merged
2 tasks
@elichai
Copy link
Copy Markdown
Member

elichai commented Jun 9, 2021

How does the use io; works?

@devrandom
Copy link
Copy Markdown
Contributor Author

devrandom commented Jun 9, 2021

How does the use io; works?

It just grabs the io module from the crate root, which is in turn is just use std::io for this PR. This is in preparation to the core2 follow-on in #603. I put it in this PR just because it was also an easy to review import change and it will keep #603 smaller.

@elichai
Copy link
Copy Markdown
Member

elichai commented Jun 9, 2021

oh right, can you maybe replace that with use crate::io so it will be more obvious? (and compatible with edition 2018)

@devrandom
Copy link
Copy Markdown
Contributor Author

devrandom commented Jun 9, 2021

Rust 1.29 doesn't support that syntax

sgeisler
sgeisler previously approved these changes Jun 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 20f6eedba9d577c86300fd5d9ab99d35ef9a0b82

Left some minor nits but overall it looks good and hopefully gets us closer to no-std.

TheBlueMatt
TheBlueMatt reviewed Jun 10, 2021
View reviewed changes
sgeisler
sgeisler approved these changes Jun 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 95aa3bf

apoelstra
apoelstra approved these changes Jun 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

95aa3bf

@TheBlueMatt TheBlueMatt merged commit e99177c into rust-bitcoin:master Jun 14, 2021
@notmandatory notmandatory mentioned this pull request Nov 8, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheBlueMatt TheBlueMatt TheBlueMatt approved these changes

@apoelstra apoelstra apoelstra approved these changes

+1 more reviewer

@sgeisler sgeisler sgeisler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@devrandom @elichai @TheBlueMatt @apoelstra @sgeisler