Implement taproot specific script helpers#604
Closed
jrawsthorne wants to merge 2 commits intorust-bitcoin:masterfrom
Closed
Implement taproot specific script helpers#604jrawsthorne wants to merge 2 commits intorust-bitcoin:masterfrom
jrawsthorne wants to merge 2 commits intorust-bitcoin:masterfrom
Conversation
e9e47be to
c805ff4
Compare
Contributor
|
There is also a dependency on #585 imo. |
dr-orlovsky
reviewed
May 18, 2021
src/blockdata/script.rs
Outdated
Collaborator
There was a problem hiding this comment.
Not sure why you are calling allocating to_vec() function just to take the reference after.
Also will need to get rid out of u5-caused unwrap, but that requires #563 merge as you said, with its WitnessVersion type
Contributor
Author
There was a problem hiding this comment.
You're right. I've removed that and added a commit to do the same for new_v0_wpkh() and new_v0_wsh()
src/blockdata/script.rs
Outdated
Comment on lines
408
to
409
Collaborator
There was a problem hiding this comment.
Not related to the PR, but just a thought that we probably need to refactor all these opcode-based version guessing via WitnessVersion API
c805ff4 to
ca90a6c
Compare
Collaborator
|
Am I right that this PR was superseded by #585? |
Member
|
ping @jrawsthorne |
Member
|
This is now done as a part of #696. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements the script parts of #503. Will rebase with changes from #563 once it's merged