Skip to content

Fix the API text files#5930

Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom
tcharding:push-zkkqnolrswxp
Apr 2, 2026
Merged

Fix the API text files#5930
apoelstra merged 1 commit intorust-bitcoin:masterfrom
tcharding:push-zkkqnolrswxp

Conversation

@tcharding
Copy link
Copy Markdown
Member

@tcharding tcharding commented Mar 31, 2026 •
edited
Loading

Run just check-api. No manual changes.

These got on master because of me in #5899.

@tcharding tcharding mentioned this pull request Mar 31, 2026
Open
@mpbagot mpbagot mentioned this pull request Apr 1, 2026
Merged
@tcharding tcharding mentioned this pull request Apr 1, 2026
Open
@mpbagot mpbagot mentioned this pull request Apr 1, 2026
Draft
@apoelstra
Copy link
Copy Markdown
Member

apoelstra commented Apr 1, 2026

c72404c needs rebase

@apoelstra
Copy link
Copy Markdown
Member

apoelstra commented Apr 1, 2026

I'm a bit lost -- I had thought that #5914 was going to fix CI. Is this actually what's needed?

@tcharding tcharding force-pushed the push-zkkqnolrswxp branch from c72404c to 49aa2e3 Compare April 2, 2026 01:26
@github-actions github-actions bot added C-consensus_encoding PRs modifying the consensus-encoding crate C-primitives labels Apr 2, 2026
@tcharding
Copy link
Copy Markdown
Member Author

tcharding commented Apr 2, 2026 •
edited
Loading

Maybe its a merge order problem, not sure. These still exist on master I believe. I fetched just now and re-ran just check-api (and I have the latest version of cargo-rbmt). But master does not have the latest version, I don't think that matters though.

@tcharding
Fix the API text files
2d66180 
Run `just check-api`. No manual changes.
@tcharding tcharding force-pushed the push-zkkqnolrswxp branch from 49aa2e3 to 2d66180 Compare April 2, 2026 01:30
@tcharding tcharding mentioned this pull request Apr 2, 2026
Open
@mpbagot mpbagot mentioned this pull request Apr 2, 2026
Draft
apoelstra
apoelstra approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2d66180; successfully ran local tests

This was referenced Apr 2, 2026
Open
Open
@apoelstra apoelstra merged commit 3b3e1ee into rust-bitcoin:master Apr 2, 2026
29 checks passed
@tcharding
Copy link
Copy Markdown
Member Author

tcharding commented Apr 2, 2026

Ah BOOM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees

No one assigned

Labels

C-consensus_encoding PRs modifying the consensus-encoding crate C-primitives

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tcharding @apoelstra