backport: consensus: Add CompactSize range check to deserialization#5921
Open
tcharding wants to merge 1 commit intorust-bitcoin:0.32.xfrom
Open
backport: consensus: Add CompactSize range check to deserialization#5921tcharding wants to merge 1 commit intorust-bitcoin:0.32.xfrom
tcharding wants to merge 1 commit intorust-bitcoin:0.32.xfrom
Conversation
Manually backport rust-bitcoin#5697. On `master` the `VarInt` type is gone but the deserialization bug fixed by 5697 exists here none the less. Add the same range check to `Decodable for VarInt`.
This was referenced Mar 29, 2026
|
I've noticed these changes were applied on master in #5697, I should have commented there first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually backport #5697. On
mastertheVarInttype is gone but the deserialization bug fixed by 5697 exists here none the less.Add the same range check to
Decodable for VarInt.