More derives for key::Error#551
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Feb 21, 2021
BP-WG:feat/key-error-derives
Merged
More derives for key::Error#551apoelstra merged 1 commit intorust-bitcoin:masterfrom BP-WG:feat/key-error-derives
apoelstra merged 1 commit intorust-bitcoin:masterfrom
BP-WG:feat/key-error-derives
Conversation
sgeisler
approved these changes
Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Underlying error types (SECP and Base58) are clonable and equatable; however the key error is neither of them. This PR fixes the issue and opens a way for more detailed clonable error types in rust-miniscript (my current WIP)