docs(hashes): replace deprecated GeneralHash references#5347
Conversation
The GeneralHash trait was removed (see CHANGELOG rust-bitcoin#4085), but internal_macros.rs still referenced it in macro docs. Updated hash_trait_impls! and general_hash_type! documentation to reflect actual current requirements
|
Hi, I've made this kind of minor pull request not for the first time, but i've seen some discussions around minor pull requests and wanted to ask you a question. If this kind of PRs really don't matter, I will stop doing it. If this matters a bit, I could go on looking for this kind of mismathes (If I'll be able to find some) and sometimes make this kind of PR (I won't be doing 1000 prs in 1 day). |
|
@Bashmunta we appreciate these kinds of minor PRs as long as they're coming from a somewhat competent human being who has some familiarity with the processes and etiquette around open-soucre development. (The fact that you even asked this suggests that you're fine on all counts.) The problem these PRs cause is that bots open them, we take the time to review and provide feedback, and then the bot responds by just closing it and disappearing, or worse, arguing with us in extended LLM prose. Either way we've wasted a bunch of our time interacting with some hostile software without our knowledge or consent. This is not why we're writing open source software. On some level it's our own fault for using a Microsoft platform but there's so-far no good alternative and it'll be a lot of work to write one.. |
The GeneralHash trait was removed (hashes/CHANGELOG.md #4085), but internal_macros.rs still referenced it in docs. Updated hash_trait_impls! and general_hash_type! documentation to reflect actual current requirements