🚨 API BREAKING CHANGE DETECTED

To see the changes click details on "Check semver breaks / PR Semver - stable toolchain" job then expand "Run semver checker script" and scroll to the end of the section.

Finally I got Claude to do something useful in a reasonable amount of time. I doubt I would have gotten the &mut &mut *r

🚨 API BREAKING CHANGE DETECTED

To see the changes click details on "Check semver breaks / PR Semver - stable toolchain" job then expand "Run semver checker script" and scroll to the end of the section.

Improved yesterdays effort by adding an additional patch that removes the need to do the &mut &mut thing.

🚨 API BREAKING CHANGE DETECTED

To see the changes click details on "Check semver breaks / PR Semver - stable toolchain" job then expand "Run semver checker script" and scroll to the end of the section.

In 8d9df9a:

Can you add a comment saying that the code you've written is equivalent to self.take(limit).read_to_end(), but you can't use this because:

• self is potentially unsized
• &mut self is sized but potentially does not implement Read (would require a blanket impl which would make "substitute io for std non-additive)

Wait. the second point is untrue. So why do we need the first commit here?

I think you can drop your first commit entirely and this will still compile.

I had assumed that you'd need to do the io::Read::take(r, limit) trick (good find, BTW) but you don't even need to do that, according to my testing.

I think you can drop your first commit entirely and this will still compile.

Yes you are right, nice.

I had assumed that you'd need to do the io::Read::take(r, limit) trick (good find, BTW) but you don't even need to do that, according to my testing.

This is nice and simple now. Cheers.

🚨 API BREAKING CHANGE DETECTED

To see the changes click details on "Check semver breaks / PR Semver - stable toolchain" job then expand "Run semver checker script" and scroll to the end of the section.

Gonna one-ACK merge -- no comments from anyone else for 2 weeks and I don't know if anyone else even cares about the io crate.

We are just ignoring the MSRV fails and hoping they magically go away, right? I.e., are you intending on merging this as is?

EDIT: Oh silly question, I had not seen all the purple in notifications. I'm trying to do useful work in the morning before looking at notifications so expect more of these sort of comments. Open to process suggestions. The problem I'm trying to solve is that notifications have a tendency to make me not want to be at the computer anymore.

I have been patiently waiting for the MSRV thing to go away for a week though and it has not ...

🚨 API BREAKING CHANGE DETECTED

To see the changes click details on "Check semver breaks / PR Semver - stable toolchain" job then expand "Run semver checker script" and scroll to the end of the section.

I have been patiently waiting for the MSRV thing to go away for a week though and it has not ...

Yes, it is a Github bug. We merged a workaround in #5310.