PSBT: making input and output field names match spec type names#513
Merged
stevenroose merged 2 commits intorust-bitcoin:masterfrom Dec 7, 2020
BP-WG:psbt/standard-names
Merged
PSBT: making input and output field names match spec type names#513stevenroose merged 2 commits intorust-bitcoin:masterfrom BP-WG:psbt/standard-names
stevenroose merged 2 commits intorust-bitcoin:masterfrom
BP-WG:psbt/standard-names
Conversation
13 tasks
apoelstra
approved these changes
Dec 6, 2020
stevenroose
approved these changes
Dec 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nit, but since we have 100% of other key names matching the BIP names, and this one does not, I think it is nice to have.
This is API breaking change, but still not hard to adopt by downstream dependencies.
PS Based on #512 since otherwise fails to build due to a bug in the master