Remove length prefix from SliceEncoder#5108
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Oct 10, 2025
Merged
Conversation
SliceEncoder
This was referenced Oct 8, 2025
jrakibi
approved these changes
Oct 9, 2025
Member
|
Needs rebase. |
Currently we hide the length prefix inside the `SliceEncoder`. While technically correct the usage of the `SliceEncoder` can be made more clear by forcing users to combine a compact size encoder and a slice encoder using an `Encoder2` instead of the current abstraction. Co-developed-by: jrakabi <j.errakibi@gmail.com>
ed02a0b to
63bbe12
Compare
Member
|
Gonna merge this -- the diff is not substantially different from @jrakibi's previous ACK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we hide the length prefix inside the
SliceEncoder. While technically correct the usage of theSliceEncodercan be made more clear by forcing users to combine a compact size encoder and a slice encoder using anEncoder2instead of the current abstraction.Original idea from jrakibi in #5104. I gave you a co-developed-by tag mate. Pushing this up because I'm itching to get
primitives 1.0.0-rc.0out.