Fix clippy lints with no-default-features#5105
Merged
apoelstra merged 4 commits intorust-bitcoin:masterfrom Oct 10, 2025
Merged
Fix clippy lints with no-default-features#5105apoelstra merged 4 commits intorust-bitcoin:masterfrom
no-default-features#5105apoelstra merged 4 commits intorust-bitcoin:masterfrom
Conversation
Clippy lint with no-default features. Make the suggested change to fix the lint.
Fix the clippy lints for the use of an explicit lifetime.
112f858 to
cc0e022
Compare
Member
|
In 01feef5 would be better IMO to feature gate on the same feature that the usage is feature gated on. |
Member
|
ACK everything else, reviewed: cc0e022 |
The structs are only used with `alloc` or `std`. Feature gate the structs, their impls and the associated import with `alloc`, which is already a dependency of `std`.
Clippy lint for a test const that is only used in an alloc feature gated test. Feature gate the cost as well.
cc0e022 to
a4be941
Compare
Contributor
Author
|
Feature gated the structs and associated implements and import. |
tcharding
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for adding crate specific clippy runs in CI with no-default-features, fix all the current lint errors when running it locally in each crate.
There is one clippy error locally in primitives from an unused import (only used with alloc), but it is fixed in #4998.