Fix arbitrary_transaction fuzz target#5054
Merged
apoelstra merged 2 commits intorust-bitcoin:masterfrom Sep 30, 2025
Merged
Conversation
Serialization before object mutation causes the test to fail
Contributor
Author
|
@apoelstra it looks like the daily cron fuzz actions have been failing since I added the one for the arbitrary weight due to the multiplication overflow (related to #4915). I think it'd make sense to remove those constructors from the fuzz test since they're deprecated and will be removed in 1.0, and it would let the fuzz action run |
Member
|
@shinghim yeah, agreed, let's remove those from the fuzz tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought I tested all of the targets I updated before I published them, but this one slipped through the cracks. Updated to move the serialization before object mutation like before, and I ran
cycle.shto make sure that there weren't any glaringly obvious bugs like the one that I pushed. Also remove some unnecessaryasserts mentioned in #5029