Skip to content

chore: fix typos and improve documentation consistency#4158

Closed
zeevick10 wants to merge 5 commits intorust-bitcoin:masterfrom
zeevick10:master
Closed

chore: fix typos and improve documentation consistency#4158
zeevick10 wants to merge 5 commits intorust-bitcoin:masterfrom
zeevick10:master

Conversation

@zeevick10
Copy link
Copy Markdown
Contributor

Description:
This PR fixes a typo in the SIGHASH constant name across multiple files:

  • Corrects SIGHASH_SIGNLE to SIGHASH_SINGLE in transaction.rs and sighash.rs
  • Updates related test cases in blockdata/script/tests.rs
  • Fixes documentation comment formatting in units/src/amount/result.rs

Files modified:

  • bitcoin/src/blockdata/transaction.rs
  • bitcoin/src/crypto/sighash.rs
  • bitcoin/src/blockdata/script/tests.rs
  • units/src/amount/result.rs

@github-actions github-actions bot added C-bitcoin PRs modifying the bitcoin crate C-units PRs modifying the units crate labels Mar 2, 2025
@apoelstra
Copy link
Copy Markdown
Member

This has two changes to test-only vectors called sht_mistakes that are supposed to contain incorrect values, and two unrelated changes.

@apoelstra
Copy link
Copy Markdown
Member

Also triggered is already spelled correctly.

@apoelstra apoelstra closed this Mar 2, 2025
@yancyribbens
Copy link
Copy Markdown
Contributor

Although, this commit does contain a valid typo fix: e876075

Probably better to open a new PR with just this commit since the others are non-sense.

@yancyribbens yancyribbens mentioned this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bitcoin PRs modifying the bitcoin crate C-units PRs modifying the units crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants