Add FIFTY_BTC const to the amount types#3915
Merged
apoelstra merged 2 commits intorust-bitcoin:masterfrom Jan 20, 2025
Merged
Conversation
The mining reward for the first epoc is 50 bitcoin. For mainnet this is old news but for regtest it is still relevant. Add and use a new const `FIFTY_BTC` to the `Amount` type. To keep the amount types uniform also add it to the `SignedAmount`.
Member
Author
|
First discussed in #3794: #3794 (comment) |
Contributor
|
ACK e002823 This is a nice addition. A lot of workflows around regtest (including tests) would benefit from this easy constant. |
Member
Author
|
Merge today please @apoelstra if you get a chance, I'm chomping at the bit to get |
Member
Author
|
BOOM! Thanks bro |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mining reward for the first epoc is 50 bitcoin. For mainnet this is old news but for regtest it is still relevant.
Add and use a new const
FIFTY_BTCto theAmounttype. To keep the amount types uniform also add it to theSignedAmount.