Refactor fee calculation code#3813
Conversation
86a9f24 to
ec81cde
Compare
|
I very intentionally did not include improvements in this PR to assist in review and reduced the need for bikeshedding. The new module is private and no changes are made, code is just moved. |
jamillambert
left a comment
There was a problem hiding this comment.
All of the code moves look good, but I find the name of the module misleading since it doesn't have all of the calculations for units. Maybe fee or fee_calc is more descriptive?
|
ooo nice, I like |
ec81cde to
6bc590f
Compare
jamillambert
left a comment
There was a problem hiding this comment.
ACK 6bc590fbf0c7a3659004dd789a1a395d2d55df45
apoelstra
left a comment
There was a problem hiding this comment.
ACK 6bc590fbf0c7a3659004dd789a1a395d2d55df45; successfully ran local tests; though the commit message calls this the calc module still
6bc590f to
cadbc11
Compare
|
Force push is change to commit log only, no code changes. |
sanket1729
left a comment
There was a problem hiding this comment.
utACK cadbc11aaed65acae43dc05fcb37e31f30fa49b5
apoelstra
left a comment
There was a problem hiding this comment.
ACK cadbc11aaed65acae43dc05fcb37e31f30fa49b5; successfully ran local tests
|
Damn, needs rebase now. |
cadbc11 to
54a8fcd
Compare
|
Weird, no merge conflicts. |
|
Needs rebase again |
We have a bunch of functions and impl blocks scattered around the place for calculating fee from fee rate and weight. In preparation for adding a `calc` module use getters and setters in code that will move to the `calc` module. (Remember, the `FeeRate` uses an inner sats per kwu value.) Internal change only.
We have a bunch of functions and impl blocks scattered around the place for calculating fee from fee rate and weight. In an effort to make the code easier to read/understand and also easier to audit introduce a private `fee` module and move all the code that is related to this calculation into it. This is in internal change only.
54a8fcd to
9d1cba4
Compare
We have a bunch of functions and impl blocks scattered around the place for calculating fee from fee rate and weight.
In an effort to make the code easier to read/understand and also easier to audit introduce a private
feemodule and move all the code that is related to this calculation into it.This is in internal change only.