Add from sat unchecked and checked to signed#3698
Closed
yancyribbens wants to merge 2 commits intorust-bitcoin:masterfrom
Closed
Add from sat unchecked and checked to signed#3698yancyribbens wants to merge 2 commits intorust-bitcoin:masterfrom
yancyribbens wants to merge 2 commits intorust-bitcoin:masterfrom
Conversation
Pull Request Test Coverage Report for Build 12214743895Details
💛 - Coveralls |
fd79c8b to
6a2a8c6
Compare
Replaced by function the panics when value is greater than MAX.
Adds a new signature which return Option and a function body that checks for cases where MAX is exceeded.
6a2a8c6 to
e1c693d
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
from_sat_uncheckedtoSignedAmountand changes the type signature offrom_satto return anOption. This segways into #3691 where the next commit would change MAX to MAX_MONEY. SinceSignedAmountis used less, it's also a simple way to prototype this change before applying the larger change toAmount.