Skip to content

backport: Deprecate Amount::fmt_value_in#3623

Merged
apoelstra merged 1 commit intorust-bitcoin:units-0.1.xfrom
tcharding:units-0.1.x
Nov 15, 2024
Merged

backport: Deprecate Amount::fmt_value_in#3623
apoelstra merged 1 commit intorust-bitcoin:units-0.1.xfrom
tcharding:units-0.1.x

Conversation

@tcharding
Copy link
Copy Markdown
Member

We an use Amount::display_in now, this was done on master in PR #2951.

We an use `Amount::display_in` now, this was done on master in PR rust-bitcoin#2951.
@github-actions github-actions bot added the C-units PRs modifying the units crate label Nov 14, 2024
@tcharding
Copy link
Copy Markdown
Member Author

I'm not sure this really matters, how much backporting do we need to do to crates depended upon by rust-bitcoin 0.32.x?

@tcharding
Copy link
Copy Markdown
Member Author

cc @shinghim, thanks for noticing this man. I did this one after seeing your #3621

Copy link
Copy Markdown
Contributor

@shinghim shinghim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 107acf3

Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 107acf3; successfully ran local tests

@apoelstra apoelstra merged commit 0279802 into rust-bitcoin:units-0.1.x Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-units PRs modifying the units crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants