Skip to content

Rename Midstate::into_parts to Midstate::to_parts since it derives Copy#3429

Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom
shinghim:3039-to
Oct 1, 2024
Merged

Rename Midstate::into_parts to Midstate::to_parts since it derives Copy#3429
apoelstra merged 1 commit intorust-bitcoin:masterfrom
shinghim:3039-to

Conversation

@shinghim
Copy link
Copy Markdown
Contributor

@shinghim shinghim commented Sep 30, 2024 •
edited by tcharding
Loading

This is a follow up to #3010

Fixes #3079

@github-actions github-actions bot added the C-hashes PRs modifying the hashes crate label Sep 30, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 30, 2024

🚨 API BREAKING CHANGE DETECTED

To see the changes click details on "Check semver breaks / PR Semver - stable toolchain" job then expand "Run semver checker script" and scroll to the end of the section.

@github-actions github-actions bot added the API break This PR requires a version bump for the next release label Sep 30, 2024
@coveralls
Copy link
Copy Markdown

coveralls commented Sep 30, 2024

Pull Request Test Coverage Report for Build 11106886024

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.619%
Changes Missing Coverage Covered Lines Changed/Added Lines %
hashes/src/sha256.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 11093198648: 0.0%
Covered Lines: 18994
Relevant Lines: 22990
💛 - Coveralls

@apoelstra
Copy link
Copy Markdown
Member

apoelstra commented Sep 30, 2024

Can you deprecate the old method?

Should backport.

@shinghim
Copy link
Copy Markdown
Contributor Author

shinghim commented Sep 30, 2024

I just browsed the source at the tag of the latest release bitcoin_hashes-0.14.0, and at that point, into_parts hadn't been introduced so i think we should be good without deprecation

@shinghim shinghim marked this pull request as ready for review September 30, 2024 13:44
@apoelstra
Copy link
Copy Markdown
Member

apoelstra commented Sep 30, 2024

Ok, perfect. Thanks for checking!

@tcharding
Copy link
Copy Markdown
Member

tcharding commented Sep 30, 2024

I edited you PR description to throw "this is a follow up to #3010" - that verifies that you are correct and we don't need to deprecate.

Thanks man!

tcharding
tcharding approved these changes Sep 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK be94c9e

apoelstra
apoelstra approved these changes Sep 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK be94c9e successfully ran local tests

@apoelstra apoelstra merged commit 66d2c02 into rust-bitcoin:master Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoelstra apoelstra apoelstra approved these changes

@tcharding tcharding tcharding approved these changes

Assignees

No one assigned

Labels

API break This PR requires a version bump for the next release C-hashes PRs modifying the hashes crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Follow up #3010 rename into_parts to to_parts

4 participants

@shinghim @coveralls @apoelstra @tcharding