hashes: Remove utils module#3299
Conversation
|
🚨 API BREAKING CHANGE DETECTED To see the changes click details on "Check semver breaks / PR Semver - stable toolchain" job then expand "Run semver checker script" and scroll to the end of the section. |
|
The API break is real, we need to deprecate. |
e6d8311 to
a959c95
Compare
|
I didn't test the deprecation, I remember it not working when I've tried this in the past but it will be interesting to see what the semver bot thinks of it. |
|
Cool, the bot likes my changes. |
Kixunil
left a comment
There was a problem hiding this comment.
ACK a959c95afb70fa3722e67e62e664c1ee823bcc35
hashes/src/lib.rs
Outdated
b3b3946 to
6a8072e
Compare
|
Rebased and improved commit logs, no other changes. Note the range diff has - #[cfg(feature = "bitcoin-io")]
- mod impls;
+ extern crate schemars;
+ And that led me to #3374 (How does one get syntax highlighting for diffs? I tried tick-tick-tick followed by |
|
(a) needs rebase again, apparently, and (b) ```diff should work. But I think the stuff you quoted is just too small and headerless to be recognizable as a diff. |
6a8072e to
40f56bf
Compare
|
#3354 conflicts with this because of the |
40f56bf to
7589d90
Compare
apoelstra
left a comment
There was a problem hiding this comment.
ACK 092d4abb443bb1d9ae8e47d62c002f74c6b483c8; successfully ran local tests
|
Merge please. |
apoelstra
left a comment
There was a problem hiding this comment.
ACK 7589d90b73448132237f9516291a353f65fba3f0; successfully ran local tests; but needs rebase
The private and public modules are already grouped, add a line of whitespace to make it _even_ more clear. Trivial I know, this patch got smaller during rebase.
The `utils` module holds public macros, call it `macros` instead.
Roll the `serde_macros` module into `macros`, requires making `macros` public but since it explicitly holds public macros this is reasonable. Keep the original module and deprecate it.
7589d90 to
5a736ed
Compare
|
Rebased, no other changes. |
We don't want dump-all module names. Remove
utilsin favour ofmacros, while we are at it roll theserde_maroscode into it as well and remove that module.Fix: #2665