Skip to content

fix: re-implement Psbt (de)serialization from/to readers/writers#3266

Merged
apoelstra merged 1 commit intorust-bitcoin:0.32.xfrom
tcharding:08-26-backport-3255-to-0.32
Sep 2, 2024
Merged

fix: re-implement Psbt (de)serialization from/to readers/writers#3266
apoelstra merged 1 commit intorust-bitcoin:0.32.xfrom
tcharding:08-26-backport-3255-to-0.32

Conversation

@tcharding
Copy link
Copy Markdown
Member

@tcharding tcharding commented Aug 28, 2024

Backportt #3255 to bitcoin v0.32.

One change is different from the original patch, import DisplayHex and remove imports of String and Vec.

@tcharding tcharding changed the base branch from master to 0.32.x August 28, 2024 23:43
@github-actions github-actions bot added the C-bitcoin PRs modifying the bitcoin crate label Aug 28, 2024
@tcharding tcharding mentioned this pull request Aug 28, 2024
Merged
@apoelstra
Copy link
Copy Markdown
Member

apoelstra commented Aug 29, 2024

bitcoin on 0cd87931efe87133aabcbb2ea1c8f365d6c6ff96 does not build with --no-default-features. (Unsure if 0.32.x is in our "broken CI" era or what. Thank goodness I fixed my local CI before this!)

@tcharding tcharding force-pushed the 08-26-backport-3255-to-0.32 branch from 0cd8793 to d5c79fd Compare August 29, 2024 20:04
@tcharding
Copy link
Copy Markdown
Member Author

tcharding commented Aug 29, 2024 •
edited
Loading

cargo test --no-default-features from workspace root gives false positive ... again :)

We were just missing use crate::prelude::{String, Vec};

apoelstra
apoelstra approved these changes Aug 29, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d5c79fd successfully ran local tests

@tcharding
Copy link
Copy Markdown
Member Author

tcharding commented Sep 1, 2024

I think we can merge this without ack from @Kixunil, its just a backport, its been open over 48 hours, and he ack'ed the original PR.

@apoelstra apoelstra merged commit 65f527b into rust-bitcoin:0.32.x Sep 2, 2024
@tcharding tcharding deleted the 08-26-backport-3255-to-0.32 branch October 24, 2024 03:59
@nyonson nyonson mentioned this pull request Mar 23, 2026
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees

No one assigned

Labels

C-bitcoin PRs modifying the bitcoin crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tcharding @apoelstra @elsirion