Merged
Conversation
We forgot to add the `ordered` feature to `test_vars.sh`.
Currently the `serde` feature requires an allocator, this is a hang over from code being written for the `bitcoin` crate. This was not found because we are not testing `primitives` correctly in CI (there is the `fuzz` bug and also `primitives` is not even in the CRATES list).
This should have been done when we introduced the `primitives` crate - epic fail. Intentionally put it before `fuzz` because of the known bug in the CI script where nothing after `fuzz` gets tested.
These were accidentally removed in rust-bitcoin#2892 and not noticed because of gaps in all of our testing infrastructure. These gaps have been since fixed.
Merged
Pull Request Test Coverage Report for Build 10512687591Details
💛 - Coveralls |
Apparently the `checkout` action will just grab random shit in the case that you configure it with an unknown key. There is a warning in the middle of the CI output so ok, I guess there's that. This commit does not change the pinned version of rust-bitcoin-maintainer-tools, though we do want to update the pin, because I want to make sure that the pin is actually working.
db4c03f to
d03e545
Compare
Member
Author
|
Added a commit which fixes the pin of rust-bitcoin-maintainer-tools. (The previous pin wasn't working, which is how CI on master here got broken; we merged a PR over there and it was automatically pulled in here.) |
Kixunil
approved these changes
Aug 22, 2024
Member
Author
|
I think we've only got a few hours before @tcharding is up so we'll wait for him to take a look. |
Member
Author
|
@tcharding can you take a look at this? |
tcharding
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebase of #3195 on master (since #3200 was merged) and adds one commit which fixes a few missing imports, which it appears was missed in the other "fix CI" PRs.