Skip to content

Panic in const context#3214

Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom
tcharding:08-22-panic-in-const
Aug 22, 2024
Merged

Panic in const context#3214
apoelstra merged 1 commit intorust-bitcoin:masterfrom
tcharding:08-22-panic-in-const

Conversation

@tcharding
Copy link
Copy Markdown
Member

Now that our MSRV is past 1.57 we can panic in const contexts.

Fix: #2427

Now that our MSRV is past 1.57 we can panic in const contexts.

Fix: rust-bitcoin#2427
@github-actions github-actions bot added C-hashes PRs modifying the hashes crate C-units PRs modifying the units crate labels Aug 22, 2024
@yancyribbens
Copy link
Copy Markdown
Contributor

Nice, much better.

Copy link
Copy Markdown
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 60b3cab

Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 60b3cab successfully ran local tests

@apoelstra apoelstra merged commit 722a723 into rust-bitcoin:master Aug 22, 2024
@tcharding tcharding deleted the 08-22-panic-in-const branch September 3, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-hashes PRs modifying the hashes crate C-units PRs modifying the units crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace with panic! post MSRV 1.57

4 participants