Conversation
Pull Request Test Coverage Report for Build 10121172375Details
💛 - Coveralls |
tcharding
left a comment
There was a problem hiding this comment.
This is a really nice improvement from a maintenance perspective, I'm excited about not writing foo-std features constantly. I only reviewed lightly but ACK from me.
ACK 966b2b5501044bc2f0e7fcf394e1970b2c0c951f
|
Looks good. However README.md needs updating also. |
|
@yancyribbens OMG, |
It also helps crates avoid weird bugs - users will get better API. |
tcharding
left a comment
There was a problem hiding this comment.
ACK 7107e6edeb58d16afaee4d901e868b77ad638804
|
Needs rebase. |
The version 1.63 satisfies our requirements for MSRV and provides significant benefits so this commit bumps it. This commit also starts using some advantages of the new MSRV, namely namespaced features, weak dependencies and the ability to use trait bounds in `const` context. This however does not yet migrade the `rand-std` feature because that requires a release of `secp256k1` with the same kind of change - bumping MSRV to 1.63 and removing `rand-std` in favor of weak dependency.
|
I wonder if I should try to do the |
|
Yeah, let's do it in a separate PR. But ACK doing it because we don't have a clear schedule for doing a rust-secp update. Nobody is pushing for one and we haven't done very much to the API over there. |
The version 1.63 satisfies our requirements for MSRV and provides significant benefits so this commit bumps it. This commit also starts using some advantages of the new MSRV, namely namespaced features, weak dependencies and the ability to use trait bounds in
constcontext.This however does not yet migrade the
rand-stdfeature because that requires a release ofsecp256k1with the same kind of change - bumping MSRV to 1.63 and removingrand-stdin favor of weak dependency. (Accompanying PR to secp256k1: rust-bitcoin/rust-secp256k1#709 )Suggested plan:
hashesandsecp256krand-stdfrombitcoin