Contributing: add instructions on wildcards in import statements#2894
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Jun 23, 2024
storopoli:doc/contributing-wildcard-instructions
Merged
Contributing: add instructions on wildcards in import statements#2894apoelstra merged 1 commit intorust-bitcoin:masterfrom storopoli:doc/contributing-wildcard-instructions
apoelstra merged 1 commit intorust-bitcoin:masterfrom
storopoli:doc/contributing-wildcard-instructions
Conversation
storopoli
commented
Jun 21, 2024
CONTRIBUTING.md
Outdated
Contributor
Author
There was a problem hiding this comment.
I don't know why we had an empty line here.
Pull Request Test Coverage Report for Build 9617622693Details
💛 - Coveralls |
Contributor
jamillambert
left a comment
There was a problem hiding this comment.
I think it looks better with a blank line before the // Rule... comments. And the one small correction. Otherwise I think it looks good.
CONTRIBUTING.md
Outdated
Contributor
There was a problem hiding this comment.
Should be use crate::prelude::{DisplayHex, String, Vec}; // OK
Contributor
Author
There was a problem hiding this comment.
Damn, how did I let this through!
My bad. I've fixed and also added empty lines before the // Rules comments.
Pull Request Test Coverage Report for Build 9618836222Details
💛 - Coveralls |
tcharding
approved these changes
Jun 21, 2024
apoelstra
approved these changes
Jun 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies the wildcard policy in
Contributing.md.Relates to #2875.