Remove usage of blockdata from paths#2885
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Jun 20, 2024
Merged
Conversation
the `blockdata` directory is code organisation thing, all the types/modules are re-exported from other places. In preparation for, and to make easier, the `primitives` crate smashing work - remove all explicit usage of `blockdata`. Note that the few instances remain as they seem required e.g., `pub(in crate::blockdata::script)` Refactor only, no logic changes.
Member
Author
|
I thought we were one-ack merging everything these days? |
Collaborator
|
@tcharding I've requested two working days of time for non-trivial things. This is fuzzy but I believe it's good enough for me. |
Member
Author
|
Two working days a week? That is legendary news for the project if so. |
Collaborator
|
I mean wait for two working days for me to review important stuff. IOW, I'm not generally available on the weekends (today is an exception :D) and since I have a lot of stuff going on I can't guarantee one working day. (Neither two but I don't want to hold up development too much.) |
Member
Author
|
Oh I got you now, thanks for clarifying. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
blockdatadirectory is code organisation thing, all the types/modules are re-exported from other places. In preparation for, and to make easier, theprimitivescrate smashing work - remove all explicit usage ofblockdata.Note that the few instances remain as they seem required e.g.,
pub(in crate::blockdata::script)Refactor only, no logic changes.
Done as part of #2883