Remove repetition for hash_newtype#2860
Remove repetition for hash_newtype#2860tcharding wants to merge 1 commit intorust-bitcoin:masterfrom
Conversation
|
Yeah, concept ACK. Maaybe we can restore this much later once |
|
Yeah agreed, for now I think uniformity and ease of patching should be top priority. |
Macros are hard enough to work on and read without adding the additional complexity from repetition. Also, since the macro call site is [hopefully] write-once-read-often code making the call site as quick to read as possible is beneficial. The changes in this patch are subjective, I'd argue that the real benefit is in the future when we work more on refactoring and improving the macro.
1a0e937 to
3b5d09c
Compare
|
I'm not against doing it in |
|
I could go either way on enforcing it on the But I definitely think it's a readablity improvement to do it in |
|
Honestly, I find the untagged ones equally readable. That could be easily because I rewrote the macro, so I'm willing to defer to majority. |
|
I just want to push I'm going to close anything that is contentious. |
Welcome to my world. I had very similar experience previously. |
Macros are hard enough to work on and read without adding the additional complexity from repetition. Also, since the macro call site is [hopefully] write-once-read-often code making the call site as quick to read as possible is beneficial.
The changes in this patch are subjective, I'd argue that the real benefit is in the future when we work more on refactoring and improving the macro.