Remove ToOwned from prelude#2279
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Dec 12, 2023
Merged
Conversation
We are not using the `ToOwned` trait, remove it. Found by clippy.
Member
Author
|
This should never have gotten onto master, our CI has wholes somewhere. |
Member
|
@tcharding I think it was a hidden merge conflict between #1225 and the PR that introduced nightly clippy in CI. CI did not catch it because it doesn't test multiple PRs' mergeability with each other, and my local scripts didn't catch it because they don't care what's in CI. |
apoelstra
approved these changes
Dec 11, 2023
This was referenced Dec 11, 2023
Merged
Member
|
Gonna one-ack merge this via the "only touches CI" carve-out, though strictly speaking this does affect a non-public API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are not using the
ToOwnedtrait, remove it.Found by clippy.