Move hash types to where they live#2178
Merged
apoelstra merged 6 commits intorust-bitcoin:masterfrom Dec 10, 2023
Merged
Conversation
Kixunil
reviewed
Nov 7, 2023
Collaborator
Kixunil
left a comment
There was a problem hiding this comment.
Hell yeah! I wanted this a long time ago and getting rid of hash_types module.
8eb07a6 to
755d71a
Compare
Member
Author
You inspired me. I rebased, and added a few additional patches fully gutting the |
apoelstra
previously approved these changes
Nov 9, 2023
Member
apoelstra
left a comment
There was a problem hiding this comment.
ACK 755d71afcc9e27b847d74f85ed61d8f51403f3ae
Closed
755d71a to
97f44d7
Compare
Member
Author
|
Rebased, no other changes. |
apoelstra
previously approved these changes
Nov 18, 2023
Member
apoelstra
left a comment
There was a problem hiding this comment.
ACK 97f44d71591e62e4c7d9b960eada74a2f358a329
Member
Author
|
Gentle bump please crew. |
97f44d7 to
7d51615
Compare
Member
Author
|
Rebased, includes some fixes to things that either were broken or got borken during rebase. Note:
|
7d51615 to
1bc2e10
Compare
apoelstra
previously approved these changes
Nov 29, 2023
Member
apoelstra
left a comment
There was a problem hiding this comment.
ACK 1bc2e10e635391b9a543ccf174c932e76fe1929e
We would like all the various hash types to be defined where they rightly live instead of in the `hash_types` module. Move the block hash types to the `block` module. While moving, add full stops to the rustdoc of each hash. Re-export _all four_ types from lib.rs (previously `WitnessMerkleNode` was not re-exported).
We would like all the various hash types to be defined where they rightly live instead of in the `hash_types` module. Move transaction hash types to the `transaction` module.
We would like all the various hash types to be defined where they rightly live instead of in the `hash_types` module. Move the BIP-158 filter hash types to the `bip158` module.
We are emptying the `hash_types` module. `impl_hashencode!` is an internal macro, as such it can live in the `internal_macros` module.
We are emptying the `hash_types` module. `impl_asref_push_bytes!` is an internal macro, as such it can live in the `internal_macros` module. While we are at it import the macro and call it without any qualifying path, this is typical for our usage of other internals/internal_macros usage.
The `hash_types` module has been emptied, it now contains only deprecated re-exports. Add a rustdoc comment stating as such.
1bc2e10 to
801c72e
Compare
Member
Author
|
Rebased and removed the trivial docs "fix", it wasn't really worth doing. |
apoelstra
approved these changes
Dec 5, 2023
Kixunil
approved these changes
Dec 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move hash types out of
hash_typesand into the modules where they are primarily used. Adds deprecated re-export so this is not a breaking change.Is an alternate solution to #2072
Resolves: #2072