ci: fuzz test YAML toolchain future-proof#2112
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Oct 8, 2023
realeinherjar:einherjar/ci-yaml-best-practices
Merged
ci: fuzz test YAML toolchain future-proof#2112apoelstra merged 1 commit intorust-bitcoin:masterfrom realeinherjar:einherjar/ci-yaml-best-practices
apoelstra merged 1 commit intorust-bitcoin:masterfrom
realeinherjar:einherjar/ci-yaml-best-practices
Conversation
To avoid YAML automatic parsing of inputs as floats, e.g. [`1.60` being parsed as `1.6`](#2109 (comment)), it is best to future-proof the `toolchain` input in CI fuzz testing as a string.
vincenzopalazzo
approved these changes
Oct 7, 2023
Contributor
vincenzopalazzo
left a comment
There was a problem hiding this comment.
ACK 3e6021b
Why not
apoelstra
approved these changes
Oct 7, 2023
tcharding
approved these changes
Oct 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid YAML automatic parsing of inputs as floats, e.g.
1.60being parsed as1.6, it is best to future-proof thetoolchaininput in CI fuzz testing as a string.